Skip to content

Conversation

@paulbalandan
Copy link
Member

Description
Apparently, Redis is not working on my laptop but the ErrorExceptions are not a graceful way to say so. Test failures should be fine.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the testing Pull requests that changes tests only label Jan 19, 2026
@paulbalandan paulbalandan changed the title tests: add sanity checks to some Redis tests test: add sanity checks to some Redis tests Jan 19, 2026
@paulbalandan paulbalandan merged commit 6594e49 into codeigniter4:develop Jan 19, 2026
47 checks passed
@paulbalandan paulbalandan deleted the fix-redis-tests-sanity branch January 19, 2026 15:10
@neznaika0
Copy link
Contributor

Is this an error after restarting the tests when the values of 101 do not match?

@paulbalandan
Copy link
Member Author

Is this an error after restarting the tests when the values of 101 do not match?

I'm getting that failure earlier where 101 does not match with 203 or something.

This fix only addresses errors on offset access on null.

@neznaika0
Copy link
Contributor

I can't check it, but I also noticed an error. It seems we need a github action without loading the cache - a restart to detect an incorrect test reset. it can be run once a week? Checking on the local PC has so far allowed us to find such errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Pull requests that changes tests only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants